Skip to content

SPLAT-2167: Added logic to webhook for AWS dedicated host support#1436

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
vr4manta:SPLAT-2167_2
Nov 20, 2025
Merged

SPLAT-2167: Added logic to webhook for AWS dedicated host support#1436
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
vr4manta:SPLAT-2167_2

Conversation

@vr4manta
Copy link
Contributor

@vr4manta vr4manta commented Nov 17, 2025 •
edited
Loading

SPLAT-2167

Changes

  • Added logic to webhook to validate fields are correct

Dependencies

Notes

Original PR was reverted due to attempt to reduce e2e dependency complexity. Removed that work to attempt in a different PR.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 17, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 17, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

SPLAT-2167

Changes

  • Added logic to webhook to validate fields are correct

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 17, 2025 •
edited by openshift-ci bot
Loading

@vr4manta: This pull request references SPLAT-2167 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

Details

In response to this:

SPLAT-2167

Changes

  • Added logic to webhook to validate fields are correct

Dependencies

Notes

Original PR was reverted due to attempt to reduce e2e dependency complexity. Removed that work to attempt in a different PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 17, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-dedicated periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-aws-ovn-dedicated

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/f84cd290-c3b0-11f0-9160-7f10bdfdfefe-0

@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 17, 2025

/payload-job periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

@vr4manta: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-nightly-4.21-e2e-vsphere-ovn

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/ff7b5aa0-c3b0-11f0-9c6e-d2107bd263d3-0

@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 17, 2025

Running the unit tests local they pass. I am gonna check to see if I can recreate the failure for:

--- FAIL: TestReconcile (2.70s)
    --- PASS: TestReconcile/machine_unhealthy (1.79s)
    --- PASS: TestReconcile/machine_unhealthy,_MHC_paused (0.06s)
    --- PASS: TestReconcile/machine_with_node_healthy (0.06s)
    --- PASS: TestReconcile/machine_with_node_healthy_but_external_remediation_annotation (0.08s)
    --- FAIL: TestReconcile/machine_with_node_likely_to_go_unhealthy (0.14s)
    --- PASS: TestReconcile/no_target:_no_machine_and_bad_node_annotation (0.13s)
    --- PASS: TestReconcile/no_target:_no_machine (0.04s)
    --- PASS: TestReconcile/machine_no_controller_owner (0.07s)
    --- PASS: TestReconcile/machine_no_noderef (0.14s)
    --- PASS: TestReconcile/machine_already_deleted (0.08s)
    --- PASS: TestReconcile/machine_healthy_with_MHC_negative_maxUnhealthy (0.04s)
    --- PASS: TestReconcile/machine_unhealthy_with_MHC_negative_maxUnhealthy (0.06s)
...
There were failures detected in the following suites:
  machinehealthcheck ./pkg/controller/machinehealthcheck
Test Suite Failed
exit status 1

@jcpowermac
Copy link
Contributor

jcpowermac commented Nov 17, 2025

/test unit

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 17, 2025

@vr4manta: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jcpowermac
Copy link
Contributor

jcpowermac commented Nov 17, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 17, 2025
@vr4manta vr4manta changed the title SPLAT-2167: SPLAT-2167: Added logic to webhook for AWS dedicated host support Nov 17, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 17, 2025

/assign @damdo

@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 19, 2025

/assign @JoelSpeed

damdo
damdo reviewed Nov 20, 2025
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2025
@vr4manta
Copy link
Contributor Author

vr4manta commented Nov 20, 2025

/verified by @vr4manta
Verified using manual testing until installer PR is merged to allow periodical to fully work.

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Nov 20, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Nov 20, 2025

@vr4manta: This PR has been marked as verified by @vr4manta.

Details

In response to this:

/verified by @vr4manta
Verified using manual testing until installer PR is merged to allow periodical to fully work.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot bot merged commit 89954cf into openshift:main Nov 20, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@damdo damdo damdo left review comments

@chrischdi chrischdi Awaiting requested review from chrischdi

@theobarberbany theobarberbany Awaiting requested review from theobarberbany

Assignees

@damdo damdo

@jcpowermac jcpowermac

@JoelSpeed JoelSpeed

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@vr4manta @openshift-ci-robot @jcpowermac @damdo @JoelSpeed